Fix Psalm error for static analysis#308
Open
p123-stack wants to merge 1 commit into
Open
Conversation
transistive
reviewed
May 25, 2026
| } | ||
| /** @var list<int> $ids */ | ||
| $ids = $path->ids; | ||
| $ids = $path->indices; |
Collaborator
There was a problem hiding this comment.
Be careful with this. Please confirm if our current minimum installable bolt version still uses ids instead of indices. In that case, we'll have to upgrade the minimum installable bolt version
Collaborator
Author
There was a problem hiding this comment.
Thanks for flagging this — I checked the current constraint (^7.1.4) and confirmed the minimum installable bolt version still uses Path::$ids only. Path::$indices was added in 7.4.0, so using indices here would break 7.1.4–7.3.x unless we bump the minimum bolt version. I can either revert back to ids or bump the constraint to ^7.4.0, whichever you’d prefer.
Collaborator
|
Let's bump it up to 7.4
Sent from [Proton Mail](https://proton.me/mail/home) for Android.
…-------- Original Message --------
On Monday, 05/25/26 at 12:36 p123-stack ***@***.***> wrote:
@p123-stack commented on this pull request.
---------------------------------------------------------------
In [src/Formatter/Specialised/BoltOGMTranslator.php](#308 (comment)):
> @@ -299,7 +299,7 @@ private function makeFromBoltPath(BoltPath $path): Path
$relationships[] = $this->makeFromBoltUnboundRelationship($rel);
}
/** @var list<int> $ids */
- $ids = $path->ids;
+ $ids = $path->indices;
Thanks for flagging this — I checked the current constraint (^7.1.4) and confirmed the minimum installable bolt version still uses Path::$ids only. Path::$indices was added in 7.4.0, so using indices here would break 7.1.4–7.3.x unless we bump the minimum bolt version. I can either revert back to ids or bump the constraint to ^7.4.0, whichever you’d prefer.
—
Reply to this email directly, [view it on GitHub](#308 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AD5MVWUN3SYINH5MOOXOJYL44PWHHAVCNFSM6AAAAACZJDQ7S6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGNJUHAZDANBSG4).
You are receiving this because you commented.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.